Tag List Report

The following document contains the listing of user tags found in the code. Below is the summary of the occurrences per tag.

Tag Total number of occurrences
@todo 3
TODO 137

Each tag is detailed below:

@todo

Number of occurrences found in the code: 3

org.itracker.services.implementations.ConfigurationServiceImpl Line
replace hardcoded version by a resource 261
get all ProjectScriptBeans with that script attached and delete the ProjectScriptBean 507
get all ProjectScriptBeans with that script attached and delete the ProjectScriptBean 572

TODO

Number of occurrences found in the code: 137

org.itracker.core.ApplicationInitialization Line
Add Javadocs here: please comment this for documentation reasons. What is this Class used for? 35
I think this should be removed... why do we need to pre-init ? (rjst) old code to pre-init fonts for jfree reports. make sure we can delete it BaseFontFactory fontFactory = BaseFontFactory.getFontFactory(); fontFactory.registerDefaultFontPath(); 81
org.itracker.core.resources.ITrackerResourceBundle Line
should dataArray be re-factored out? 41
org.itracker.core.resources.ITrackerResourcesTest Line
set languageDAO of ConfigurationService 89
org.itracker.model.Configuration Line
every configuration item should have a name, similar to a Java property in a properties file. A description would be nice to have too. name + version should be the natural key. (note: we shouldn't allow 2 configuration items with the same name and version, but with different types). </p> 43
org.itracker.model.CustomField Line
use type-safe enum CustomField.DateFormat 98
org.itracker.model.IssueActivityTypeTest Line
Remove call to depreciated code 12
org.itracker.model.IssueField Line
throw IllegalArgumentException instead of IssueException ? 255
throw IllegalArgumentException instead of IssueException ? 331
org.itracker.model.NotificationTest Line
remove method from Notification 38
org.itracker.model.Project Line
it would be a Set, not list 90
org.itracker.model.User Line
it would be a Set, not list 70
org.itracker.model.WorkflowScript Line
what's the expected type here? private Collection projectFields; 53
org.itracker.persistence.dao.BaseHibernateDaoImplTest Line
fails currently try { dao.save(l); fail("entity is already persisted, save must throw DataAccessException"); } catch (DataAccessException dae) { // OK } 55
Auto-generated method stub 254
org.itracker.persistence.dao.IssueActivityDAO Line
rename to findByIssue() 20
org.itracker.persistence.dao.PermissionDAOImplTest Line
fix implementation or test 30
org.itracker.persistence.dao.ProjectDAOImplTest Line
Activate skipped, ignored Test (when implementation is done correctly) 46
org.itracker.persistence.dao.UserDAOImplTest Line
Activate skipped, ignored Test (when implementation is done correctly) 73
fix this, users.size seems to be 5 sometimes? 78
fails, please fix 95
org.itracker.selenium.CreateIssueTest Line
--No comment-- 118
org.itracker.services.IssueService Line
Add Javadocs here: document this whole class.describe what is the use for this method. 144
shall we deprecate this one? why do we need to give it a userId? 189
org.itracker.services.NotificationService Line
whats its use? 101
org.itracker.services.authentication.AbstractPluggableAuthenticator Line
Rewrite Javadocs here: we don't have session beans or EJBs anymore 28
org.itracker.services.authentication.adsson.GetUserModelFromADPrivilegedAction Line
Add Javadocs here 23
org.itracker.services.authentication.adsson.WindowsSSONAuthenticator Line
get user from jcifs 55
org.itracker.services.implementations.ConfigurationServiceImpl Line
Cleanup this file, go through all issues, todos, etc. 69
make final static? 74
never used, therefore commented, task added: Vector currentIds = new Vector(); 365
org.itracker.services.implementations.ITrackerServicesImpl Line
clean up messy stuff by refactoring 12
Cleanup this file, go through all issues, todos, etc. 23
org.itracker.services.implementations.IssueServiceImpl Line
Cleanup this file, go through all issues, todos, etc. 94
move to {@link NotificationService} 213
maybe it has no use at all. is it obsolete? when I'd set the issue-fields on an issue and then save/update issue, would it be good enough? 638
There is no relation saved to database yet? 900
configurationService should be set from context 1131
activity for adding attachment? IssueActivity activityAdd = new IssueActivity(attachment.getIssue(), user, IssueActivity.Type.ATTACHEMENT_ADDED) 1314
move to {@link NotificationService} ? 1477
org.itracker.services.implementations.IssueServiceTest Line
test function for unavailable projects 189
test function for unavailable projects 216
test getUnassignedIssues(true) 258
please somebody do tests on populate (multiple?) custom fields on an issue Test method for {@link org.itracker.services.IssueService#setIssueFields(java.lang.Integer, java.util.List)} . 543
org.itracker.services.implementations.NotificationServiceImpl Line
Cleanup this file, go through all issues, todos, etc. 62
final debugging/integration/implementation 437
Decide if this code is really needed and document for what 438
localize.. 659
check these 3 lines - do we need them?: notifications.addAll(issue.getNotifications()); notifications.add(notification); issue.setNotifications(notifications); 815
is it needed to update issue too? 820
url should be automatically generated by configuration (baseurl) and notification (issue-id). 1029
org.itracker.services.implementations.NotificationServiceTest Line
should be different owner and creator, projectowners 112
org.itracker.services.implementations.ProjectServiceImpl Line
Cleanup this file, go through all issues, todos, etc. 51
Add Javadocs here: document this whole class. 52
implement Locale-aware ProjectFields. 237
check this: why is this comment "script.remove()" there? Which type is expected in Collection<T> scripts? (WorkflowsScript? ProjectScript? Do you understand this? - I would say ProjectScript) Collection<ProjectScript> scripts = project.getScripts(); scripts.remove(script); 296
Decide if this code is really needed and document for what 353
Decide if this code is really needed and document for what 363
Decide if this code is really needed and document for what 369
Decide if this code is really needed and document for what 375
Decide if this code is really needed and document for what 381
org.itracker.services.implementations.ReportServiceImpl Line
Temporarily commenting out code to remove pnuts dependency Will need to test for regressions. if(jr.getQuery() != null) { List objects = (List)Pnuts.eval(jr.getQuery().getText(), new Context()); beanCollectionDataSource = new JRBeanCollectionDataSource(objects); } else { 124
org.itracker.services.implementations.UserServiceImpl Line
use a factory to hide this. 723
don't swallow exceptions!! MUST be propagated to the caller!! 743
org.itracker.services.util.ImportHandler Line
handle configuration for setting the BASE label 280
org.itracker.services.util.IssueUtilitiesTest Line
make tests using the database where appropriat (setup testdata from datasets) 35
prepare with services 673
org.itracker.services.util.NamingUtilitiesTest Line
Add Javadocs here: what is the purpose of this class? 13
org.itracker.services.util.ProjectUtilitiesTest Line
Activate skipped, ignored Test (when implementation is done correctly) 46
org.itracker.services.util.UserUtilities Line
Could use an enumeration 55
must we really use this BASE64Encoder()? it seems to be not support by jrockit rt.jar hash = Base64.encodeBytes(raw); 200
org.itracker.services.util.WorkflowUtilities Line
should issue, project, user, services be available too? 235
remove currentValue from bshInterpreter, it's a collection of current values. 258
is this necessary? It should stay the same list-object.. currentValues = (List<NameValuePair>)bshInterpreter.get("currentValue"); 264
error-handling..? 277
org.itracker.web.actions.PortalHomeAction Line
Action Cleanup 37
since repeating code, set a common Comparator variable to contain the Comparator to use and execute the sort pre issue type only once. 135
set the next value based on the request attribute! 254
org.itracker.web.actions.ShowHelpAction Line
Action Cleanup 29
org.itracker.web.actions.admin.AdminHomeAction Line
performance issue when attachments size needs to be calculated over many issues ! select sum(size) from IssueAttachment 166
org.itracker.web.actions.admin.configuration.EditConfigurationAction Line
Action Cleanup 61
is this inteded? 223
need to fix this RJST activity.setIssue(issues.get(i)); 227
org.itracker.web.actions.admin.configuration.EditCustomFieldActionUtil Line
there is some bugs around here still, needs debugging. See jsp error output. 44
the following two lines have not been used, commented, task added String languageKey = "translations(" + language + ")"; Vector locales = (Vector) languages_map.get(language); 48
org.itracker.web.actions.admin.configuration.EditCustomFieldFormAction Line
Action Cleanup 47
org.itracker.web.actions.admin.configuration.EditCustomFieldValueFormAction Line
Action Cleanup 59
it looks like to following 3 lines can be removed, we comment them and add a task. 70
org.itracker.web.actions.admin.configuration.ImportDataProcessAction Line
, removed name attribute, so it's defaulted to the key 141
, removed name attribute, so it's defaulted to the key 145
it looks like the following method is not used; commented and task added private void printArray(AbstractBean[] models) { for(int i = 0; i < models.length; i++) { logger.debug(i + ") " + models[i].toString()); } } 304
org.itracker.web.actions.admin.configuration.RemoveConfigurationItemAction Line
Action Cleanup 49
org.itracker.web.actions.admin.project.AdminProjectUtilities Line
needed? If user is no more owner, he can still be admin Collection<User> currentOwners = projectService .getProjectOwners(project.getId()); 94
org.itracker.web.actions.admin.report.EditReportFormAction Line
Action Cleanup 28
never used, therefore commented, task added UserModel user = (UserModel) session.getAttribute(Constants.USER_KEY); 45
org.itracker.web.actions.base.ItrackerBaseAction Line
Action Cleanup 54
Deprecate and move to {@link org.itracker.web.util.LoginUtilities} 80
Deprecate and move to {@link org.itracker.web.util.LoginUtilities} 106
Deprecate and move to new static method in a ITrackerServicesFactory-class 184
move to static utility-method in {@link LoginUtilities} 258
Clean and split this code up, so it is understandable what it does. 260
org.itracker.web.actions.preferences.EditPreferencesAction Line
Action Cleanup 65
the following checks make no sense from my perspective. This check should happen in the ExecuteAlways filter maybe Shall we remove it? 80
should this check happen earlier? 147
org.itracker.web.actions.preferences.EditPreferencesFormAction Line
Action Cleanup 61
remove this hack, this should be handled central, there are other instances of this hack 94
org.itracker.web.actions.project.CreateIssueAction Line
Action Cleanup 78
org.itracker.web.actions.project.CreateIssueFormAction Line
Action Cleanup 74
org.itracker.web.actions.project.EditIssueAction Line
can we make this token optional (configurable) and probably by form, not over the whole app.. 72
org.itracker.web.actions.project.EditIssueActionUtil Line
why do we need to updateIssue here, and can not later? issueService.updateIssue(issue, user.getId()); 350
simplify this code, it's not readable, unsave yet. 546
org.itracker.web.actions.project.EditIssueFormAction Line
Sort attachments Collections.sort(attachments, IssueAttachment.CREATE_DATE_COMPARATOR); 131
org.itracker.web.actions.project.ListIssuesActionUtil Line
check for other occurences for this constants and maybe place somewhere else? 37
check from here... 187
check to here... 200
org.itracker.web.actions.project.MoveIssueAction Line
is seems first condition is not necessary 144
return detailed messages on the missing authorization 145
org.itracker.web.actions.project.ViewIssueAction Line
Action Cleanup 44
verify this code. 77
org.itracker.web.actions.report.DisplayReportAction Line
Action Cleanup 70
All Issues this is huge, remove if possible 82
org.itracker.web.actions.user.LoginAction Line
Deprecated code. Can we get rid of it? Why is it so complicated?? We only want to iknow if success or no success 165
no information about login-credentials should be shown 240
org.itracker.web.filters.ExecuteAlwaysFilter Line
itracker.web.generic.unknown for unknown user? 184
this should be configured per-instance. Request server-name should only be used for exception and logged (configuration not found!) 308
remove deprecated currLocale attribute 325
org.itracker.web.forms.CustomFieldValueForm Line
setup request env for validation output 113
org.itracker.web.ptos.ProjectPTO Line
Code Cleanup: this method is not used and I don't like the name (what does setup stand for?) 154
Decide if this code is really needed and document for what 155
org.itracker.web.scheduler.tasks.MailNotification Line
never used, commented, task added: int totalMessages = src_folder.getMessageCount(); 107
process message 129
org.itracker.web.servlets.GenericController Line
Rewrite Javadocs here This needs documentation. Is it still used? What is it used for? How? It is referenced by AttachementDownloadController, (@deprecated Use org.itracker.web.actions.admin.attachment.DownloadAttachmentAction instead.) ReportChartController, ReportDownloadController 45
org.itracker.web.servlets.ReportDownloadController Line
the 2-3 lines are most propably not used; commented, task added Commented more not used lines, but added a task for testing. HttpSession session = request.getSession(); UserModel user = (UserModel) session.getAttribute("user"); User user = (session == null ? null : (User) session.getAttribute(Constants.USER_KEY)); 54
org.itracker.web.taglib.FormatCustomFieldTag Line
why not work with option-id here? if value contains quotes, problem. 134
org.itracker.web.util.LoginUtilities Line
the order of retrieving locale from request should be: <ol> <li>request-attribute Constants.LOCALE_KEY</li> <li>request-param 'loc'</li> <li>session attribute <code>Constants.LOCALE_KEY</code></li> <li>cookie 'loc'</li> <li>request.getLocale()/request.getLocales()</li> <li>ITrackerResources.DEFAULT_LOCALE</li> </ol> </p> 148
this is a hack, remove when possible 398
org.itracker.web.util.ServletContextUtils Line
In fact this shouldn't be needed / used, ITracker's JSP have way too much java code 14
R.Ø.S.A.