PMD Results

The following document contains the results of PMD 4.2.2.

Files

org/itracker/core/ApplicationInitialization.java

Violation Line
Avoid unused constructor parameters such as 'reportService'. 55 - 60

org/itracker/core/resources/ITrackerResources.java

Violation Line
Avoid unused imports such as 'org.itracker.web.util.LoginUtilities' 35
Avoid unused local variables such as 'bundle'. 341

org/itracker/model/CustomField.java

Violation Line
Avoid unused constructor parameters such as 'name'. 150 - 153

org/itracker/persistence/dao/IssueDAOImpl.java

Violation Line
Avoid empty if statements 568 - 569

org/itracker/services/implementations/ConfigurationServiceImpl.java

Violation Line
Avoid unused imports such as 'org.itracker.model.util.PropertiesFileHandler' 48
These nested if statements could be combined 132 - 134
Do not use if statements that are always true or always false 601
Avoid empty if statements 749 - 752
Avoid empty catch blocks 780 - 781
These nested if statements could be combined 1092 - 1105

org/itracker/services/implementations/NotificationServiceImpl.java

Violation Line
These nested if statements could be combined 952 - 956

org/itracker/services/implementations/ProjectServiceImpl.java

Violation Line
Avoid unused local variables such as 'user'. 421
These nested if statements could be combined 433 - 435

org/itracker/services/implementations/UserServiceImpl.java

Violation Line
Avoid unused constructor parameters such as 'reportDAO'. 122 - 130
Avoid unused constructor parameters such as 'projectDAO'. 122 - 130
Avoid empty catch blocks 207 - 209
Avoid empty if statements 483 - 485
Avoid unused local variables such as 'i'. 792

org/itracker/services/util/HTMLUtilities.java

Violation Line
Avoid unused imports such as 'java.text.DateFormat' 21
Avoid unused imports such as 'java.text.SimpleDateFormat' 22
Avoid unused imports such as 'java.util.StringTokenizer' 23
Avoid unnecessary temporaries when converting primitives to Strings 157

org/itracker/services/util/ImportHandler.java

Violation Line
Avoid empty if statements 278 - 281

org/itracker/services/util/IssueUtilities.java

Violation Line
These nested if statements could be combined 128 - 130
These nested if statements could be combined 679 - 686
These nested if statements could be combined 771 - 777

org/itracker/services/util/SystemConfigurationUtilities.java

Violation Line
Avoid unused imports such as 'org.itracker.model.Language' 29

org/itracker/web/actions/admin/AdminHomeAction.java

Violation Line
Avoid unused local variables such as 'numberDefinedKeys'. 92

org/itracker/web/actions/admin/configuration/EditConfigurationAction.java

Violation Line
These nested if statements could be combined 182 - 237

org/itracker/web/actions/admin/configuration/EditCustomFieldActionUtil.java

Violation Line
Avoid unused imports such as 'java.util.Dictionary' 5
Avoid unused imports such as 'java.util.SortedMap' 11
Avoid unused imports such as 'java.util.TreeMap' 12
Avoid unused imports such as 'org.apache.commons.collections.MapUtils' 17

org/itracker/web/actions/admin/configuration/EditCustomFieldValueAction.java

Violation Line
Avoid unused local variables such as 'highestSortOrder'. 87

org/itracker/web/actions/admin/configuration/ImportDataProcessAction.java

Violation Line
Avoid unused method parameters such as 'ic'. 118 - 160
Avoid unused method parameters such as 'importer'. 118 - 160
Avoid unused method parameters such as 'ic'. 162 - 188
Avoid unused method parameters such as 'importer'. 162 - 188
Avoid unused method parameters such as 'ic'. 190 - 231
Avoid unused method parameters such as 'ic'. 233 - 302

org/itracker/web/actions/admin/configuration/ImportDataVerifyAction.java

Violation Line
Avoid unused method parameters such as 'ic'. 136 - 248
Avoid unused method parameters such as 'ic'. 250 - 287
Avoid unused method parameters such as 'ic'. 289 - 330
Avoid unused method parameters such as 'ic'. 332 - 340

org/itracker/web/actions/admin/configuration/OrderCustomFieldValueAction.java

Violation Line
Avoid unused imports such as 'java.util.ArrayList' 22

org/itracker/web/actions/admin/language/EditLanguageAction.java

Violation Line
Avoid empty catch blocks 177 - 179

org/itracker/web/actions/admin/language/EditLanguageFormAction.java

Violation Line
Avoid unused imports such as 'java.util.Iterator' 28
Avoid unused imports such as 'java.util.ResourceBundle' 32
Avoid unused imports such as 'java.util.Set' 33
Avoid unused imports such as 'org.itracker.core.resources.ITrackerResourceBundle' 48
These nested if statements could be combined 120 - 129

org/itracker/web/actions/admin/project/EditProjectFormActionUtil.java

Violation Line
Avoid unused imports such as 'org.itracker.services.util.WorkflowUtilities' 35

org/itracker/web/actions/admin/project/EditProjectScriptFormAction.java

Violation Line
Avoid unused local variables such as 'i'. 108

org/itracker/web/actions/admin/report/EditReportAction.java

Violation Line
Avoid empty if statements 103 - 105
Avoid empty if statements 106 - 108

org/itracker/web/actions/admin/user/EditUserAction.java

Violation Line
Avoid unused imports such as 'java.util.HashSet' 24
Avoid unused imports such as 'org.itracker.web.util.LoginUtilities' 48

org/itracker/web/actions/admin/workflow/EditWorkflowScriptAction.java

Violation Line
Avoid empty if statements 71 - 82

org/itracker/web/actions/issuesearch/SearchIssuesFormAction.java

Violation Line
Invoke equals() on the object you've already ensured is not null 139

org/itracker/web/actions/preferences/EditPreferencesFormAction.java

Violation Line
Avoid unused imports such as 'java.util.LinkedHashMap' 22

org/itracker/web/actions/project/CreateIssueAction.java

Violation Line
These nested if statements could be combined 209 - 217
Avoid unused method parameters such as 'issue'. 375 - 382
Avoid unused method parameters such as 'issueForm'. 375 - 382

org/itracker/web/actions/project/EditIssueActionUtil.java

Violation Line
Avoid unused method parameters such as 'user'. 188 - 262
Avoid unused method parameters such as 'issueService'. 188 - 262
Avoid unused method parameters such as 'issueService'. 277 - 312
Avoid unused method parameters such as 'issueService'. 314 - 360
These nested if statements could be combined 378 - 384
Avoid empty if statements 656 - 658
Avoid empty if statements 709 - 711

org/itracker/web/actions/project/ListIssuesActionUtil.java

Violation Line
Avoid empty catch blocks 134 - 135
These nested if statements could be combined 182 - 184
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 206

org/itracker/web/actions/project/MoveIssueAction.java

Violation Line
Avoid unused method parameters such as 'mapping'. 121 - 132

org/itracker/web/actions/project/MoveIssueFormAction.java

Violation Line
These nested if statements could be combined 151 - 156

org/itracker/web/actions/report/DisplayReportAction.java

Violation Line
Avoid unused method parameters such as 'request'. 209 - 226

org/itracker/web/filters/ExecuteAlwaysFilter.java

Violation Line
These nested if statements could be combined 127 - 139

org/itracker/web/forms/ProjectForm.java

Violation Line
Avoid empty if statements 78 - 79

org/itracker/web/servlets/AttachmentDownloadController.java

Violation Line
Avoid unnecessary return statements 118

org/itracker/web/servlets/GenericController.java

Violation Line
Avoid unused private fields such as 'logger'. 63

org/itracker/web/servlets/ReportDownloadController.java

Violation Line
Avoid unnecessary return statements 88

org/itracker/web/taglib/AddErrorTag.java

Violation Line
Avoid empty catch blocks 72 - 73

org/itracker/web/taglib/ClearErrorsTag.java

Violation Line
Avoid empty catch blocks 59 - 60

org/itracker/web/taglib/FormatCustomFieldTag.java

Violation Line
Avoid unused private fields such as 'logger'. 48

org/itracker/web/taglib/FormatHistoryEntryTag.java

Violation Line
Avoid empty catch blocks 170 - 171

org/itracker/web/taglib/FormatResolutionTag.java

Violation Line
Avoid empty catch blocks 95 - 96
Avoid empty catch blocks 101 - 103

org/itracker/web/util/AttachmentUtilities.java

Violation Line
These nested if statements could be combined 180 - 183

org/itracker/web/util/LoginUtilities.java

Violation Line
These nested if statements could be combined 54 - 65
R.Ø.S.A.