PMD Results

The following document contains the results of PMD 4.2.2.

Files

org/itracker/core/ApplicationInitialization.java

ViolationLine
Avoid unused imports such as 'javax.jws.soap.InitParam'33
Avoid unused constructor parameters such as 'reportService'.57 - 61

org/itracker/core/resources/ITrackerResources.java

ViolationLine
Avoid unused local variables such as 'bundle'.340

org/itracker/model/CustomField.java

ViolationLine
Avoid unused constructor parameters such as 'name'.150 - 153

org/itracker/persistence/dao/IssueDAOImpl.java

ViolationLine
Avoid empty if statements568 - 569

org/itracker/services/implementations/ConfigurationServiceImpl.java

ViolationLine
These nested if statements could be combined131 - 133
Do not use if statements that are always true or always false600
Avoid empty if statements748 - 751
Avoid empty catch blocks779 - 780
These nested if statements could be combined1091 - 1104

org/itracker/services/implementations/NotificationServiceImpl.java

ViolationLine
These nested if statements could be combined969 - 973

org/itracker/services/implementations/ProjectServiceImpl.java

ViolationLine
Avoid unused local variables such as 'user'.421
These nested if statements could be combined433 - 435

org/itracker/services/implementations/UserServiceImpl.java

ViolationLine
Avoid unused constructor parameters such as 'projectDAO'.122 - 130
Avoid unused constructor parameters such as 'reportDAO'.122 - 130
Avoid empty catch blocks207 - 209
Avoid empty if statements483 - 485
Avoid unused local variables such as 'i'.792

org/itracker/services/util/HTMLUtilities.java

ViolationLine
Avoid unnecessary temporaries when converting primitives to Strings153

org/itracker/services/util/ImportHandler.java

ViolationLine
Avoid empty if statements278 - 281

org/itracker/services/util/IssueUtilities.java

ViolationLine
These nested if statements could be combined128 - 130
These nested if statements could be combined674 - 681
These nested if statements could be combined766 - 772

org/itracker/web/actions/ShowHelpAction.java

ViolationLine
Avoid unused imports such as 'java.io.File'3

org/itracker/web/actions/admin/AdminHomeAction.java

ViolationLine
Avoid unused local variables such as 'numberDefinedKeys'.92

org/itracker/web/actions/admin/configuration/EditConfigurationAction.java

ViolationLine
These nested if statements could be combined190 - 245

org/itracker/web/actions/admin/configuration/EditCustomFieldValueAction.java

ViolationLine
Avoid unused local variables such as 'highestSortOrder'.87

org/itracker/web/actions/admin/configuration/ImportDataProcessAction.java

ViolationLine
Avoid unused method parameters such as 'ic'.118 - 160
Avoid unused method parameters such as 'importer'.118 - 160
Avoid unused method parameters such as 'ic'.162 - 188
Avoid unused method parameters such as 'importer'.162 - 188
Avoid unused method parameters such as 'ic'.190 - 231
Avoid unused method parameters such as 'ic'.233 - 302

org/itracker/web/actions/admin/configuration/ImportDataVerifyAction.java

ViolationLine
Avoid unused method parameters such as 'ic'.136 - 248
Avoid unused method parameters such as 'ic'.250 - 287
Avoid unused method parameters such as 'ic'.289 - 330
Avoid unused method parameters such as 'ic'.332 - 340

org/itracker/web/actions/admin/language/EditLanguageAction.java

ViolationLine
Avoid empty catch blocks177 - 179

org/itracker/web/actions/admin/language/EditLanguageFormAction.java

ViolationLine
These nested if statements could be combined116 - 125

org/itracker/web/actions/admin/project/EditProjectScriptFormAction.java

ViolationLine
Avoid unused local variables such as 'i'.108

org/itracker/web/actions/admin/report/EditReportAction.java

ViolationLine
Avoid empty if statements103 - 105
Avoid empty if statements106 - 108

org/itracker/web/actions/admin/workflow/EditWorkflowScriptAction.java

ViolationLine
Avoid empty if statements71 - 82

org/itracker/web/actions/feed/RssFeedAction.java

ViolationLine
Overriding method merely calls super16 - 19

org/itracker/web/actions/issuesearch/SearchIssuesFormAction.java

ViolationLine
Invoke equals() on the object you've already ensured is not null139

org/itracker/web/actions/project/CreateIssueAction.java

ViolationLine
These nested if statements could be combined209 - 217
Avoid unused method parameters such as 'issueForm'.375 - 382
Avoid unused method parameters such as 'issue'.375 - 382

org/itracker/web/actions/project/EditIssueActionUtil.java

ViolationLine
Avoid unused method parameters such as 'issueService'.188 - 262
Avoid unused method parameters such as 'user'.188 - 262
Avoid unused method parameters such as 'issueService'.277 - 312
Avoid unused method parameters such as 'issueService'.314 - 360
These nested if statements could be combined378 - 384
Avoid empty if statements656 - 658
Avoid empty if statements709 - 711

org/itracker/web/actions/project/ListIssuesActionUtil.java

ViolationLine
Avoid unused imports such as 'java.net.URL'3
Avoid empty catch blocks135 - 136
These nested if statements could be combined184 - 186
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.208

org/itracker/web/actions/project/MoveIssueAction.java

ViolationLine
Avoid unused method parameters such as 'mapping'.121 - 132

org/itracker/web/actions/project/MoveIssueFormAction.java

ViolationLine
These nested if statements could be combined151 - 156

org/itracker/web/actions/report/DisplayReportAction.java

ViolationLine
Avoid unused method parameters such as 'request'.209 - 226

org/itracker/web/actions/user/SelfRegisterAction.java

ViolationLine
Avoid unused imports such as 'org.itracker.services.ITrackerServices'39
Avoid unused imports such as 'org.itracker.web.util.RequestHelper'47

org/itracker/web/filters/ExecuteAlwaysFilter.java

ViolationLine
These nested if statements could be combined127 - 139

org/itracker/web/forms/ProjectForm.java

ViolationLine
Avoid empty if statements78 - 79

org/itracker/web/ptos/ProjectScriptPTO.java

ViolationLine
Avoid unused imports such as 'org.itracker.model.Project'5
Avoid unused imports such as 'org.itracker.services.util.IssueUtilities'8

org/itracker/web/servlets/AttachmentDownloadController.java

ViolationLine
Avoid unnecessary return statements118

org/itracker/web/servlets/GenericController.java

ViolationLine
Avoid unused private fields such as 'logger'.66

org/itracker/web/servlets/ReportDownloadController.java

ViolationLine
Avoid unnecessary return statements88

org/itracker/web/servlets/RssFeedController.java

ViolationLine
Avoid unused imports such as 'com.sun.syndication.feed.synd.SyndCategory'6
Avoid unused imports such as 'com.sun.syndication.feed.synd.SyndCategoryImpl'7
Avoid unused imports such as 'com.sun.syndication.io.impl.RSS20Generator'10
Avoid unused imports such as 'org.itracker.services.util.ProjectUtilities'20
Avoid unused imports such as 'org.itracker.web.util.LoginUtilities'23
Avoid unused imports such as 'org.springframework.util.StringUtils'27
Avoid unused imports such as 'java.io.ByteArrayOutputStream'36
Avoid unused imports such as 'java.util.regex.MatchResult'39
Overriding method merely calls super57 - 60
Avoid unused local variables such as 'f'.102
Avoid unused method parameters such as 'p'.217 - 304
Avoid unused local variables such as 'statusLocalizedString'.244
Avoid unused local variables such as 'severityLocalizedString'.244
Avoid unused local variables such as 'componentsSize'.244

org/itracker/web/taglib/AddErrorTag.java

ViolationLine
Avoid empty catch blocks72 - 73

org/itracker/web/taglib/ClearErrorsTag.java

ViolationLine
Avoid empty catch blocks59 - 60

org/itracker/web/taglib/FormatCustomFieldTag.java

ViolationLine
Avoid unused private fields such as 'logger'.56
Avoid empty catch blocks225 - 227
Avoid empty catch blocks227 - 229
Avoid unused private methods such as 'formatDate(Date,ResourceBundle)'.329

org/itracker/web/taglib/FormatHistoryEntryTag.java

ViolationLine
Avoid empty catch blocks170 - 171

org/itracker/web/taglib/FormatResolutionTag.java

ViolationLine
Avoid empty catch blocks95 - 96
Avoid empty catch blocks101 - 103

org/itracker/web/util/AttachmentUtilities.java

ViolationLine
These nested if statements could be combined180 - 183

org/itracker/web/util/LoginUtilities.java

ViolationLine
These nested if statements could be combined54 - 65

R.Ø.S.A.